Skip to content

Conversation

@Youssef1313
Copy link

Reasons for making this change

This reverts #2483 per discussion in there.

Links to documentation supporting these rule changes

https://learn.microsoft.com/dotnet/standard/library-guidance/strong-naming

✔️ CONSIDER adding the strong naming key pair (public + private) to your source control system.

Merge and Approval Steps

  • Confirm that you've read the contribution guidelines and ensured your PR aligns
  • Ensure CI is passing
  • Get a review and Approval from one of the maintainers

Copilot AI review requested due to automatic review settings December 28, 2025 12:18
@Youssef1313 Youssef1313 requested a review from a team as a code owner December 28, 2025 12:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts a previous change (PR #2483) that added a commented-out rule for *.snk (strong name key) files in the VisualStudio gitignore template. The revert aligns with Microsoft's official guidance that recommends adding strong naming key pairs to source control. The change cleanly removes the 4-line comment block that warned against including strong name files.

  • Removes the commented-out #*.snk rule and its explanatory comment
  • Aligns with Microsoft's strong naming guidance for .NET libraries

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant