Fixed http client code generator

[abocim]

This PR fixes a bug we have hit within http client code generator.

In case two or more Methods using Payload(ArrayOf(...)) are defined, generator generates HTTP request body builder function for the first of defined Method only (client/types.go file).

Bug can be reproduced using new added unit test.

Goa design code:

       var PayloadA = Type("PayloadA", func() {
               Attribute("a", String, func() {
                       Pattern("patterna")
               })
       })
       var PayloadB = Type("PayloadB", func() {
               Attribute("a", String, func() {
                       Pattern("patterna")
               })  
               Attribute("b", String, func() {
                       Pattern("patternb")
               })  
               Required("a", "b")
       })  
       Service("ServiceMultipleMethods", func() {
               Method("MethodA", func() {
                       Payload(ArrayOf(PayloadA))
                       HTTP(func() {
                               POST("/")
                       })
               })
               Method("MethodB", func() {
                       Payload(ArrayOf(PayloadB))
                       HTTP(func() {
                               PUT("/")
                       })
               })
       })

Bug is located in http/codegen/client_types.go: func clientType:
In this function there is incorrectly used data.Name attribute for already seen payload types. Attribute is always set to "array" value regardless of real payload type.

Fix:
Using of data.Ref attribute instead, the problem is solved. Since its value corresponds to the real type of Payload "[]*PayloadARequestBody" resp. "[]*PayloadBRequestBody". The code for the both func NewPayloadARequestBody() and func NewPayloadBRequestBody() is properly generated.

[raphael]

Nice catch! thanks for the nice PR.

[abocim]

I'm sorry for failed checks before. I updated the source a little.
Now, the both unit tests and integreation tests are passing ok.

[raphael]

No worries, thanks for the fix!