Fix: Implicitly marking parameter as nullable is deprecated#2653
Open
thefrosty wants to merge 2 commits intogodaddy-wordpress:masterfrom
Open
Fix: Implicitly marking parameter as nullable is deprecated#2653thefrosty wants to merge 2 commits intogodaddy-wordpress:masterfrom
thefrosty wants to merge 2 commits intogodaddy-wordpress:masterfrom
Conversation
…nullable type must be used instead
thefrosty
commented
Dec 5, 2025
| * @return StylesLoader|static | ||
| */ | ||
| public static function setInstance( StylesLoader $instance = null ) { | ||
| public static function setInstance( StylesLoader $instance ) { |
Contributor
Author
There was a problem hiding this comment.
I wouldn't assume you would want to set an instance as null, so I just removed the default null value instead of explicitly setting nullable in the StylesLoader.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2652
Types of changes
Adds explicit nullable types.
How has this been tested?
Acceptance criteria
Checklist: