feat(gooddata-sdk): [AUTO] add deployment info fields to CatalogOrganizationAttributes#1341
Closed
yenkins-admin wants to merge 2 commits intomasterfrom
Closed
feat(gooddata-sdk): [AUTO] add deployment info fields to CatalogOrganizationAttributes#1341yenkins-admin wants to merge 2 commits intomasterfrom
yenkins-admin wants to merge 2 commits intomasterfrom
Conversation
…izationAttributes Add 'region' and 'data_center' optional fields to CatalogOrganizationAttributes and update CatalogOrganization.from_api() to read these fields from the API response. The fields map to the new @ApiOutOnly 'region' and 'dataCenter' fields in the Organization model exposed by the metadata-api when ENABLE_DEPLOYMENT_INFO feature flag is enabled. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
yenkins-admin
requested review from
hkad98,
jaceksan,
lupko and
pcerny
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose new read-only deployment info fields (
region,data_center) from the Organization API response in the SDK wrapper'sCatalogOrganizationAttributes.P016 | https://github.com/gooddata/gdc-nas/actions/runs/22176850727
What changed in gdc-nas
Commit f0f3783 adds two new output-only fields
regionanddataCenterto theOrganizationmodel inmetadata-api. These fields are conditionally populated byOrganizationServicewhen theENABLE_DEPLOYMENT_INFOfeature flag is enabled. The OpenAPI spec exposes:region: nullable string — current deployment cluster namedataCenter: nullable string — current deployment regionThe
gooddata-api-clientwas already regenerated and containsdata_centerandregionas optional fields inJsonApiOrganizationOutAttributes.What was implemented in SDK
region: Optional[str] = Noneanddata_center: Optional[str] = Nonefields toCatalogOrganizationAttributesdataclassCatalogOrganization.from_api()to readattributes.regionandattributes.data_centerfrom the API responseregionanddataCenterin mocked API response bodyFiles modified
packages/gooddata-sdk/src/gooddata_sdk/catalog/organization/entity_model/organization.pypackages/gooddata-sdk/tests/catalog/fixtures/organization/organization.yamlpackages/gooddata-sdk/tests/catalog/test_catalog_organization.pyJIRA: DX-TBD (pending Jira Sandbox availability)
Risk: Low