feat(gooddata-sdk): [AUTO] add exclude_user_settings parameter to resolve settings methods#1342
Closed
yenkins-admin wants to merge 2 commits intomasterfrom
Closed
feat(gooddata-sdk): [AUTO] add exclude_user_settings parameter to resolve settings methods#1342yenkins-admin wants to merge 2 commits intomasterfrom
yenkins-admin wants to merge 2 commits intomasterfrom
Conversation
…olve settings methods Expose the new excludeUserSettings query parameter (added in backend PR #20044) in the SDK wrapper methods resolve_all_workspace_settings and resolve_workspace_settings. Both methods now accept exclude_user_settings: bool = False and forward it to the underlying API client calls, allowing callers to bypass user-level setting overrides. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
yenkins-admin
requested review from
hkad98,
jaceksan,
lupko and
pcerny
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose the new
exclude_user_settingsquery parameter on SDK workspace settings resolution methods, allowing callers to bypass user-level setting overrides.P017 | https://github.com/gooddata/gdc-nas/actions/runs/22176850727
What changed in gdc-nas
PR #19914 (be4d3d3): Wired fiscal calendar activation state into LDM generation.
DataSourceServicenow resolvesActiveCalendarsSettingand passes it intoGenerateLdmContext.AnonymousLdmGenerator.getDateGranularities()now requires both thefiscalCalendarsEnabledfeature flag ANDactiveCalendars.fiscal=trueto include fiscal granularities.ActiveCalendarsSetting.fiscaldefault changed fromtruetofalse.PR #20044 (8ce1041): Added
excludeUserSettingsboolean query parameter (defaultfalse) to all four resolve-settings endpoints (workspaceResolveAllSettings,workspaceResolveSettings,resolveAllSettingsWithoutWorkspace,resolveSettingsWithoutWorkspace). Whentrue, user-level settings are excluded from resolution. OpenAPI spec updated accordingly. Thegooddata-api-clientwas already regenerated to exposeexclude_user_settingson the corresponding methods.What was implemented in SDK
Added
exclude_user_settings: bool = Falseparameter toresolve_all_workspace_settings()andresolve_workspace_settings()inCatalogWorkspaceService. The parameter is forwarded to the underlying API client calls (workspace_resolve_all_settingsandworkspace_resolve_settings), allowing SDK consumers to bypass user-level setting overrides when resolving workspace settings. Default value ofFalsemaintains full backward compatibility.Files modified
sdk/packages/gooddata-sdk/src/gooddata_sdk/catalog/workspace/service.pyJIRA: DX (pending – Jira sandbox in maintenance at time of PR creation)
Risk: Low