feat(gooddata-sdk): [AUTO] add exclude_user_settings param to workspace settings resolution#1344
Open
yenkins-admin wants to merge 1 commit intomasterfrom
Open
feat(gooddata-sdk): [AUTO] add exclude_user_settings param to workspace settings resolution#1344yenkins-admin wants to merge 1 commit intomasterfrom
yenkins-admin wants to merge 1 commit intomasterfrom
Conversation
…ce settings resolution Expose the new excludeUserSettings query parameter (added in gdc-nas PR #20044) through the SDK wrapper methods resolve_all_workspace_settings and resolve_workspace_settings. Both methods now accept exclude_user_settings: bool = False and forward it to the underlying API client calls. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
yenkins-admin
requested review from
hkad98,
jaceksan,
lupko and
pcerny
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
exclude_user_settingsparameter to SDK workspace settings resolution methods, exposing theexcludeUserSettingsquery parameter introduced in gdc-nas.P010 | Workflow: https://github.com/gooddata/gdc-nas/actions/runs/22179401494
What changed in gdc-nas
be4d3d3 (PR #19914): Changed
ActiveCalendarsSetting.fiscaldefault fromtruetofalse; LDM generation now only includes fiscal date granularities when theACTIVE_CALENDARSsetting is explicitly enabled. JIRA: F1-22248ce1041 (PR #20044): Added
excludeUserSettingsboolean query parameter (default:false) to fourSettingControllerREST endpoints (workspaceResolveAllSettings,workspaceResolveSettings,resolveAllSettingsWithoutWorkspace,resolveSettingsWithoutWorkspace). Whentrue, skips user-layer setting resolution. OpenAPI spec updated (38 additions). JIRA: F1-2229What was implemented in SDK
Added
exclude_user_settings: bool = Falsekeyword argument to two wrapper methods ingooddata-sdkand forwarded the parameter to the underlying API client calls (which already supportexclude_user_settingsin the regenerated client).Files modified
sdk/packages/gooddata-sdk/src/gooddata_sdk/catalog/workspace/service.py—resolve_all_workspace_settings()andresolve_workspace_settings()now accept and propagateexclude_user_settingsJIRA: F1-2229 (https://gooddata.atlassian.net/browse/F1-2229)
Risk: Low