feat(gooddata-sdk): [AUTO] add allowed_relationship_types to ai_chat and ai_chat_stream#1346
Open
yenkins-admin wants to merge 1 commit intomasterfrom
Open
feat(gooddata-sdk): [AUTO] add allowed_relationship_types to ai_chat and ai_chat_stream#1346yenkins-admin wants to merge 1 commit intomasterfrom
yenkins-admin wants to merge 1 commit intomasterfrom
Conversation
…and ai_chat_stream Expose the new allowedRelationshipTypes ChatRequest field via the SDK wrapper. Both ai_chat() and ai_chat_stream() in ComputeService now accept an optional allowed_relationship_types parameter (list[AllowedRelationshipType]) that is forwarded to the API client. AllowedRelationshipType is also re-exported from gooddata_sdk.__init__ for convenient SDK consumer imports. Tests added for both methods with the new parameter. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
yenkins-admin
requested review from
hkad98,
jaceksan,
lupko and
pcerny
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose the
allowedRelationshipTypesfield added to the GenAI Chat API in gdc-nas by wiring the new optionalallowed_relationship_typesparameter through the gooddata-sdk wrapper methodsai_chat()andai_chat_stream().P006 | Workflow: https://github.com/gooddata/gdc-nas/actions/runs/22179401494
What changed in gdc-nas
Merged PR #20108 (commit 85777a0):
allowedRelationshipTypes: List<AllowedRelationshipType>?field toChatRequestdata class inChat.ktopen-api-spec.json) to add theallowedRelationshipTypesarray property to theChatRequestschemagen_ai.proto) to addrepeated AllowedRelationshipType allowed_relationship_types = 26to theChatRequestmessageGenAIProcessor.ktto map the new field to gRPCAllowedRelationshipTypeprotobuf objectsgen_ai_service_servicer.py,chat_service.py,search_settings.py,search_request_handler.py)relationship_filter.py, removing ~150 lines of duplicated logic fromsearch_service.pyWhat was implemented in SDK
Branch:
feature/auto-P006-allowed-relationship-types-chat(commitfb87e46)allowed_relationship_types: Optional[list[AllowedRelationshipType]] = Noneparameter toai_chat()andai_chat_stream()inComputeService; value is forwarded toChatRequestwhen providedAllowedRelationshipTypefrom the auto-generatedgooddata_api_clientand re-exported it fromgooddata_sdk.__init__so SDK consumers can import it directlytest_ai_chat_with_allowed_relationship_typesandtest_ai_chat_stream_with_allowed_relationship_typestest cases demonstrating the new parameterFiles modified
packages/gooddata-sdk/src/gooddata_sdk/compute/service.pypackages/gooddata-sdk/src/gooddata_sdk/__init__.pypackages/gooddata-sdk/tests/compute/test_compute_service.pyJIRA: DX-TBD (pending Jira sandbox availability)
Risk: Low