feat(gooddata-sdk): [AUTO] add exclude_user_settings parameter to resolve workspace settings methods#1350
Open
yenkins-admin wants to merge 2 commits intomasterfrom
Open
feat(gooddata-sdk): [AUTO] add exclude_user_settings parameter to resolve workspace settings methods#1350yenkins-admin wants to merge 2 commits intomasterfrom
yenkins-admin wants to merge 2 commits intomasterfrom
Conversation
…olve workspace settings methods Adds optional exclude_user_settings parameter to resolve_all_workspace_settings() and resolve_workspace_settings() in CatalogWorkspaceService, forwarding it to the underlying API client calls to support organization/workspace-level setting resolution without user-level overrides (PR #20044). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
yenkins-admin
requested review from
hkad98,
jaceksan,
lupko and
pcerny
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add optional
exclude_user_settingsparameter toresolve_all_workspace_settings()andresolve_workspace_settings()in the SDK workspace settings service.P007 | Workflow: https://github.com/gooddata/gdc-nas/actions/runs/22181963264
What changed in gdc-nas
PR #19914 (be4d3d3): Changed default value of
ActiveCalendarsSetting.fiscalfromtruetofalse. Made LDM generation conditionally include fiscal granularities only when the fiscal calendar is active per settings.PR #20044 (8ce1041): Added new optional query parameter
excludeUserSettings(boolean, default=false) to all four setting resolution endpoints (GET/POST/workspaces/{id}/resolveSettings,GET/POST/resolveSettings). Whentrue, user-level settings are excluded from resolution so callers can request organization/workspace-level settings without user-level overrides.What was implemented in SDK
Updated
CatalogWorkspaceServiceto expose the newexcludeUserSettingsbackend parameter:resolve_all_workspace_settings()— accepts optionalexclude_user_settings: Optional[bool] = Noneand forwards it toworkspace_resolve_all_settings()when provided.resolve_workspace_settings()— accepts optionalexclude_user_settings: Optional[bool] = Noneand forwards it toworkspace_resolve_settings()when provided.Added four unit tests verifying the parameter is forwarded correctly when
Trueand omitted when not specified.Files modified
packages/gooddata-sdk/src/gooddata_sdk/catalog/workspace/service.pypackages/gooddata-sdk/tests/catalog/test_catalog_workspace.pyJIRA: PENDING (Jira ticket will be created after review)
Risk: Low