convert NDK build to docker build, and use NDK r29#1104
Merged
dneto0 merged 2 commits intogoogle:mainfrom Jan 26, 2026
Merged
Conversation
Collaborator
Author
|
i haven't tested this locally, so I'm crossing my fingers |
dneto0
force-pushed
the
ndk-build-docker
branch
from
9b2c9c7 to
eb7874f
Compare
Collaborator
Author
|
Needed to do a |
dneto0
force-pushed
the
ndk-build-docker
branch
from
eb7874f to
c2abead
Compare
dj2
approved these changes
Jan 26, 2026
Co-authored-by: dan sinclair <dj2@everburning.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Docker image already has the NDK.
So don't download it on each run.
Also, we don't need to download ninja; also, the build script doesn't use it.