Fix building for Android CMake toolchain#1105
Merged
dneto0 merged 1 commit intogoogle:mainfrom Jan 26, 2026
Merged
Conversation
Collaborator
Author
|
Note: the kokoro/android build is currently disabled via Google-internal config. |
dneto0
commented
Jan 23, 2026
Collaborator
Author
|
internal reference crbug.com/478302715 |
dj2
approved these changes
Jan 26, 2026
The Android NDK r29 does not have Vulkan 1.4 headers. So conditionalize use of Vulkan 1.4 header structs. Also, when building with the Android CMake toolchain, the vulkan engine has to link against the `log` library.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Android NDK r29 does not have Vulkan 1.4 headers.
So conditionalize use of Vulkan 1.4 header structs.
Also, when building with the Android CMake toolchain,
the vulkan engine has to link against the
loglibrary.