Open
Conversation
Switch from http to https (license in source file, ...)
tbroyer
reviewed
Apr 1, 2021
Comment on lines
+16
to
18
| https://travis-ci.com to validate your branches before you even put them into | ||
| pull requests. All pull requests will be validated by Travis CI in any case | ||
| and must pass before being merged. |
There was a problem hiding this comment.
This needs to be reworked as the project has switched from Travis CI to GitHub Actions.
cpovirk
reviewed
Apr 1, 2021
Member
cpovirk
left a comment
cpovirk
left a comment
There was a problem hiding this comment.
If you're up for making the updates that tbroyer suggests, we'd be happy to take those. As noted inline, though, I think we should leave the URLs as they are.
| Apache License | ||
| Version 2.0, January 2004 | ||
| http://www.apache.org/licenses/ | ||
| https://www.apache.org/licenses/ |
Member
There was a problem hiding this comment.
In general, I think we're advised to keep the license text exactly as it is. And I notice that even the copy of the license that is served from https (that is, from https://www.apache.org/licenses/LICENSE-2.0) uses http: links.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR