Support alternate JavaCompilers (such as ECJ) in JavaSourcesSubject#80
Support alternate JavaCompilers (such as ECJ) in JavaSourcesSubject#80doanduyhai wants to merge 1 commit intogoogle:mainfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
There was a problem hiding this comment.
Would be even better if you somehow merged #71 into that one wrt passing a JavaCompiler to the CompilationRule rather than always using ToolProvider.getSystemJavaCompiler(). Sure one can easily be rebased on the other anyway…
There was a problem hiding this comment.
Sure, as soon as @tbroyer fixes the file manager thing
|
👍 Lacking tests running with the Eclipse compiler though to make sure everything works OK. |
|
Actually, I'd be happy to see this and #71 get merged into one p/r. |
|
Hello here, no new ? #71 is still not merged yet so I'm stuck with my PR ... |
New syntax to inject custom compiler: