This repository was archived by the owner on Dec 8, 2025. It is now read-only.
Conversation
The script now works for spirv-opt and LLPC, and has the option to output just numbers of unique signatures, which is useful for gathering statistics to put in a spreadsheet.
paulthomson
approved these changes
Nov 15, 2020
Contributor
paulthomson
left a comment
paulthomson
left a comment
There was a problem hiding this comment.
Approved, with a suggestion for the TODO.
Comment on lines
+58
to
+59
| start_line = i + 1 | ||
| # TODO: Is there a reliable way to find the end of a spirv-opt failure? |
Contributor
There was a problem hiding this comment.
Maybe:
- Don't break once a bug is found (for the cases you added).
- if found_bug, do something different:
- Just look for "Exec (verbose): ..." to find the next "reduce" command, set the end line based on this and then break.
- if we find "gfauto_interestingness_test: finished ..." then the output above this is actually the output from part of a reduction, so something has gone wrong.
- if we don't find anything else and get to the end of the file, this is also fine. It just means we did not do a reduction and the file immediately ends after the "Command failed:" output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The script now works for spirv-opt and LLPC, and has the option to
output just numbers of unique signatures, which is useful for
gathering statistics to put in a spreadsheet.