This repository was archived by the owner on Dec 8, 2025. It is now read-only.
Open
Conversation
This change applies floor() to the uses of gl_FragCoord in order to eliminate the potential ambiguity of having 0.5 in the source values. This should improve the stability of the shaders in fuzzing.
paulthomson
reviewed
Dec 7, 2021
Contributor
There was a problem hiding this comment.
Thanks for doing this. I would like to hear Ally's opinion. Some initial thoughts: maybe we should only do this for stable_ shaders. Also, if there are statements like gl_FragCoord.x < ..., then I think we can (and should) avoid flooring in this case. Also, I wonder if doing - 0.5 instead of floor might trigger different compiler behavior; not sure which is best though. I suppose we could do a mix. I think the use of gl_FragCoord.x in the gfauto texture generation code is possibly the most worrying because the results are stored into an 8 bit value, but of course we can address that in a different PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change applies floor() to the uses of gl_FragCoord in order to
eliminate the potential ambiguity of having 0.5 in the source values.
This should improve the stability of the shaders in fuzzing.