This repository was archived by the owner on Jan 21, 2026. It is now read-only.
Fix circular dependend import#343
Open
onur wants to merge 1 commit intogoogle:masterfrom
onur:fix-circular-dependent-imports
Open
Fix circular dependend import#343onur wants to merge 1 commit intogoogle:masterfrom onur:fix-circular-dependent-imports
onur wants to merge 1 commit intogoogle:masterfrom
onur:fix-circular-dependent-imports
Conversation
Python3 is givin an error when we try to import gumbo[1]:
ImportError: No module named 'gumboc_tags'
This is because __init__.py is importing everything and gumboc_tags
already imported.
This patch is fixing this issue.
[1]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=789299
Contributor
|
Travis is giving a test failure for this - it looks like it breaks Python 2? Maybe try "from . import gumboc_tags" - I've seen this fix similar errors on other projects? |
Author
|
It's just breaking tests because PYTHONPATH is not defined. |
|
Actually, the patch doesn't work either: No idea why. I'm having library path issues, but I'm not sure how that interacts here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python3 is givin an error when we try to import gumbo1:
This is because init.py is importing everything and gumboc_tags
already imported.
This patch is fixing this issue.