Don't use <ctype.h> functions

[DemiMarie]

They're locale-dependent, whereas HTML parsing is locale-agnostic.

[kevinhendricks]

Should isspace include \v the vertical tab, since that is part of isspace in the C locale and it is typically included as whitespace? Or is this character explicitly excluded in the whatwg spec

[kevinhendricks]

FWIW, Checked both the w3c and whatwg spec and whitespace characters for the purposes of the spec do NOT include the vertical tab \v char.

[kevinhendricks]

Agreed. If you are looking to a simpler set of patches without all of the whitespace changes, you may want to look at: https://github.com/kevinhendricks/gumbo-parser/commits/updated The last couple commits on this branch are my attempt to pull all critical bug fixes into one place ("updated") except for the out-of-memory changes as they change the parser structure size and thus the abi. For out-of-memory, I think your approach of aborting in your own malloc is probably the safest approach. What use is a null or partial tree given we do not know how partial it may be? So I would rather have it abort. Feel free to grab whatever you need as these are simply modifications of current pull requests along with a few other fixes we have discussed before.

…

On Oct 12, 2017, at 8:17 AM, Craig Barnes ***@***.***> wrote: 50,000 line diffs for 20 line bug fixes considered harmful... — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.