Add an option to skip dependency installation for CMake#71
Open
alexeibs wants to merge 1 commit intogoogle:masterfrom
Open
Add an option to skip dependency installation for CMake#71alexeibs wants to merge 1 commit intogoogle:masterfrom
alexeibs wants to merge 1 commit intogoogle:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
CMakeLists.txtis configured in a way that the build dependencies are downloaded (such asabseil-cppandgoogletest) automatically during the build process. This can make it difficult to includerobotstxtinto other C++ projects as a submodule which is a common practice in C++ ecosystem. If a project is already usinggoogletestorabseil-cpp, then it's possible to get 2 different versions of the same library in the same project which is not ideal and might cause linker issues.This PR introduces
ROBOTS_SKIP_DEPSwhich allows to skip dependency installation and access the dependencies by other means (i.e.find_package).