This repository was archived by the owner on Oct 30, 2025. It is now read-only.
Crash with report when call getValue() on operands returns null#355
Open
zhengyang92 wants to merge 1 commit intogoogle:mainfrom
Open
Crash with report when call getValue() on operands returns null#355zhengyang92 wants to merge 1 commit intogoogle:mainfrom
zhengyang92 wants to merge 1 commit intogoogle:mainfrom
Conversation
zhengyang92
changed the title
Contributor
|
I think it might be better to add a single check around like 421 of this file |
Contributor
Author
|
@regehr John, are you saying putting a fatal null check for NewVal in line 421, instead of just reporting and continue? |
Contributor
|
I'm just saying that there's already code in the pass (in runOnFunction) to check for failure of getValue() and print something, if we report the fatal error there, it's only one place to change in the code instead of multiple places like this patch currently has |
Contributor
|
can you replace this patch with a very small one that hooks into the place where getValue() is originally called, rather than changing getValue() itself? |
zhengyang92
force-pushed
the
pass-select-support
branch
from
542df03 to
8994701
Compare
Contributor
|
hey @manasij7479 coud you look into the failing tests here and see if they stem from pass bugs? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.