Skip to content

Conversation

@joshlf
Copy link
Member

@joshlf joshlf commented Jan 22, 2026

...and remove two that are currently in the codebase.


Latest Update: v3 — Compare vs v2

📚 Full Patch History

Links show the diff between the row version and the column version.

Version v2 v1 Base
v3 vs v2 vs v1 vs Base
v2 vs v1 vs Base
v1 vs Base

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @joshlf, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on cleaning up the test suite by removing outdated UI test .stderr files. This action ensures that the test environment remains lean and relevant, eliminating artifacts that were meant to be deleted in a prior commit and thus improving the overall maintainability of the test infrastructure.

Highlights

  • Stale UI Test File Removal: Two .stderr files, transmute-mut-src-dst-unsized.stderr and transmute-ref-src-dst-unsized.stderr, have been removed from the tests/ui-stable/ directory. These files contained expected error output for UI tests and were no longer relevant.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@joshlf joshlf requested a review from jswrenn January 22, 2026 18:45
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes two stale .stderr files from the UI test suite. As the description notes, these files should have been removed in a previous commit, so this is a good cleanup. The changes are straightforward and correct.

@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.90%. Comparing base (7cc13f1) to head (cb90955).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2909   +/-   ##
=======================================
  Coverage   91.90%   91.90%           
=======================================
  Files          20       20           
  Lines        5877     5877           
=======================================
  Hits         5401     5401           
  Misses        476      476           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@jswrenn jswrenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sneaky. I suppose there might be some value in a CI job that checks for orphaned stderr files.

@joshlf joshlf changed the title [tests] Remove stale UI test .stderr files [ci] Check for orphaned UI test .stderr files Jan 22, 2026
@joshlf joshlf force-pushed the G31f38f3a71e4f8e878e91a9e0d53fd34b4f4d8cb branch from 450f99d to bb8ec06 Compare January 22, 2026 19:33
@joshlf
Copy link
Member Author

joshlf commented Jan 22, 2026

Oh, sneaky. I suppose there might be some value in a CI job that checks for orphaned stderr files.

Updated the PR to do that too.

@joshlf joshlf force-pushed the G31f38f3a71e4f8e878e91a9e0d53fd34b4f4d8cb branch from bb8ec06 to bd011be Compare January 22, 2026 19:38
Base automatically changed from Gba34c175d9c27344e336de4ed088eb0754d87f30 to main January 22, 2026 19:45
...and remove two that are currently in the codebase.

gherrit-pr-id: G31f38f3a71e4f8e878e91a9e0d53fd34b4f4d8cb
@joshlf joshlf force-pushed the G31f38f3a71e4f8e878e91a9e0d53fd34b4f4d8cb branch from bd011be to cb90955 Compare January 22, 2026 19:50
@joshlf joshlf enabled auto-merge January 22, 2026 19:50
@joshlf joshlf added this pull request to the merge queue Jan 22, 2026
Merged via the queue into main with commit 6aae3de Jan 22, 2026
104 checks passed
@joshlf joshlf deleted the G31f38f3a71e4f8e878e91a9e0d53fd34b4f4d8cb branch January 22, 2026 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants