-
Notifications
You must be signed in to change notification settings - Fork 137
[ci] Check for orphaned UI test .stderr files #2909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @joshlf, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on cleaning up the test suite by removing outdated UI test Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request removes two stale .stderr files from the UI test suite. As the description notes, these files should have been removed in a previous commit, so this is a good cleanup. The changes are straightforward and correct.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2909 +/- ##
=======================================
Coverage 91.90% 91.90%
=======================================
Files 20 20
Lines 5877 5877
=======================================
Hits 5401 5401
Misses 476 476 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jswrenn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, sneaky. I suppose there might be some value in a CI job that checks for orphaned stderr files.
450f99d to
bb8ec06
Compare
Updated the PR to do that too. |
bb8ec06 to
bd011be
Compare
...and remove two that are currently in the codebase. gherrit-pr-id: G31f38f3a71e4f8e878e91a9e0d53fd34b4f4d8cb
bd011be to
cb90955
Compare
...and remove two that are currently in the codebase.
Latest Update: v3 — Compare vs v2
📚 Full Patch History
Links show the diff between the row version and the column version.