[transmute] Remove SizeEq super-trait bound
#2920
Conversation
Summary of ChangesHello @joshlf, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the flexibility of pointer transmutation by relaxing the preconditions on the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2920 +/- ##
=======================================
Coverage 91.90% 91.91%
=======================================
Files 20 20
Lines 5883 5890 +7
=======================================
+ Hits 5407 5414 +7
Misses 476 476 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request successfully refactors the transmute functionality by introducing a more generic transmute_with method and removing the SizeEq super-trait bound from TryTransmuteFromPtr. This change enhances flexibility by allowing any CastExact type for address- and size-preserving casts, aligning with the goal of reducing SizeEq implementations across the codebase. The safety comments and documentation have been updated to reflect these changes accurately.
Relax the preconditions on `TryTransmuteFromPtr` to permit *any* address- and size-preserving cast, not just `SizeEq::CastFrom`. This preserves the same safety semantics, but permits any `C: CastExact` cast as the underlying cast. This will allow us to perform transmutes more easily in situations where it is difficult to emit `SizeEq` impls, and will generally allow us to reduce the number of `SizeEq` impls required across the codebase. gherrit-pr-id: G0973aa3261bb811a53f7d99b8d38df5d6c328d52
joshlf
force-pushed
the
G0973aa3261bb811a53f7d99b8d38df5d6c328d52
branch
from
dd3f8d1 to
ed4b47f
Compare
2 participants
Relax the preconditions on
TryTransmuteFromPtrto permit anyaddress- and size-preserving cast, not just
SizeEq::CastFrom. Thispreserves the same safety semantics, but permits any
C: CastExactcastas the underlying cast. This will allow us to perform transmutes more
easily in situations where it is difficult to emit
SizeEqimpls, andwill generally allow us to reduce the number of
SizeEqimpls requiredacross the codebase.
TryTransmuteFromPtrparams #2921unsafe_with_size_eq!withtransmute_with#2923SizeEqimpls #2922SizeEqsuper-trait bound #2920Latest Update: v18 — Compare vs v17
📚 Full Patch History
Links show the diff between the row version and the column version.