-
Notifications
You must be signed in to change notification settings - Fork 23
tests: filter warnings related to deprecated python versions #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @parthea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue where Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to filter warnings related to deprecated Python versions by adding new rules to pytest.ini. While the intent is correct, the regular expressions used for filtering are overly broad and could lead to unintentionally suppressing other warnings. I've provided a suggestion to make the patterns more specific and robust, ensuring they only match the intended warnings.
| ignore:.*Please upgrade to the latest Python version.*:FutureWarning | ||
| ignore:(?s).*using a Python version.*past its end of life.*:FutureWarning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These regular expressions can be made more specific to improve clarity and prevent unintentionally matching other warnings. The filterwarnings option matches patterns from the start of the warning message.
- The pattern
.*Please upgrade to the latest Python version.*is too broad and will match both warnings you are trying to filter, making the second filter redundant. - The pattern
(?s).*using a Python version.*past its end of life.*is also broad, and the(?s)flag is unnecessary for single-line warnings.
Using more specific patterns anchored to the beginning of each warning message is a more robust approach.
ignore:Please upgrade to the latest Python version:FutureWarning
ignore:You are using a Python version that is past its end of life.*:FutureWarning
Fixes #208