cleanup(pubsub)!: move the BasePublisher out of crate::client::*#4637
Open
suzmue wants to merge 1 commit intogoogleapis:mainfrom
Open
cleanup(pubsub)!: move the BasePublisher out of crate::client::*#4637suzmue wants to merge 1 commit intogoogleapis:mainfrom
suzmue wants to merge 1 commit intogoogleapis:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4637 +/- ##
==========================================
+ Coverage 95.02% 95.03% +0.01%
==========================================
Files 196 196
Lines 7551 7551
==========================================
+ Hits 7175 7176 +1
+ Misses 376 375 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
coryan
approved these changes
Feb 12, 2026
Collaborator
coryan
left a comment
coryan
left a comment
There was a problem hiding this comment.
I think this is fine, but I am not seeing the whole picture. Maybe run it by somebody who does?
PhongChuong
approved these changes
Feb 12, 2026
Resource sharing between publishers is an advanced use case. Moving the BasePublisher out of the main entry point (crate::client::*) simplifies the discoverability of the Publisher for most of our users while still leaving it accessible. It is likely we will also want to export the Publisher from this module as well (and apply the same to the subscriber). For googleapis#4282
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resource sharing between publishers is an advanced use case. Moving the BasePublisher out of the main entry point (crate::client::*) simplifies the discoverability of the Publisher for most of our users while still leaving it accessible. It is likely we will also want to export the Publisher from this module as well (and do the same with the Subscriber).
For #4282