chore: Migrate IntegerLabelToDatetimeOp operator to SQLGlot #2310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
chelsea-lin
requested changes
Jan 9, 2026
| to=sge.DataType.build("INT64"), | ||
| ), | ||
| ), | ||
| to=_dtype_to_sql_string(y.dtype), # type: ignore |
Contributor
There was a problem hiding this comment.
we can call sqlglot_types.from_bigframes_dtype instead and remove "# type: igore"
| this=first, to=sge.DataType.build("BIGNUMERIC") | ||
| ), | ||
| ), | ||
| to=sge.DataType.build("INT64"), |
Contributor
There was a problem hiding this comment.
to="INT64" works too and can simple the expression a little bit. If so, can we apply to all the "to" parameter of the "sge.Cast" method?
sycai
reviewed
Jan 9, 2026
Comment on lines
+483
to
+511
| us = n * 7 * 24 * 60 * 60 * 1000000 | ||
| first = sge.func( | ||
| "UNIX_MICROS", | ||
| sge.Add( | ||
| this=sge.TimestampTrunc( | ||
| this=sge.Cast(this=y.expr, to="TIMESTAMP"), | ||
| unit=sge.Var(this="WEEK(MONDAY)"), | ||
| ), | ||
| expression=sge.Interval( | ||
| this=sge.convert(6), unit=sge.Identifier(this="DAY") | ||
| ), | ||
| ), | ||
| ) | ||
| x_label = sge.Cast( | ||
| this=sge.func( | ||
| "TIMESTAMP_MICROS", | ||
| sge.Cast( | ||
| this=sge.Add( | ||
| this=sge.Mul( | ||
| this=sge.Cast(this=x.expr, to="BIGNUMERIC"), | ||
| expression=sge.convert(us), | ||
| ), | ||
| expression=sge.Cast(this=first, to="BIGNUMERIC"), | ||
| ), | ||
| to="INT64", | ||
| ), | ||
| ), | ||
| to=sqlglot_types.from_bigframes_dtype(y.dtype), | ||
| ) |
Contributor
There was a problem hiding this comment.
Style nit: could we define separate helper functions to handle different frequencies? This would help reduce the size of the function _integer_label_to_datetime_op_non_fixed_frequency and improve readability.
The improved function should look like this
def _integer_label_to_datetime_op_non_fixed_frequency():
....
if rule_code is weekly:
return _integer_label_to_datetime_op_weekly_freq()
elif rule_code is monthly:
....
chelsea-lin
approved these changes
Jan 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes b/447388852 🦕