Skip to content

osvscanner: add missing edge case test #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
academo merged 1 commit into from
Feb 13, 2026
Merged

osvscanner: add missing edge case test #511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions pkg/analysis/passes/osvscanner/lockfile/parse-pnpm-lock_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,19 @@ func TestParsePnpmLock_Dependencies(t *testing.T) {
require.NoError(t, err)
require.Len(t, packages[4].Dependencies, 15)
}

// Regression test for https://github.com/grafana/plugin-validator/pull/282
// Corrupted lockfiles with malformed package keys should be handled gracefully.
func TestParsePnpmLock_CorruptedLockfile(t *testing.T) {
t.Parallel()
aLockfile := filepath.Join("..", "testdata", "node", "corrupted-pnpm", "pnpm-lock.yaml")
packages, err := ParsePnpmLock(aLockfile)
require.NoError(t, err)
// Only the 2 valid packages should be parsed, corrupted entries should be skipped
require.Len(t, packages, 2)
// Packages are sorted alphabetically by name
require.Equal(t, "another-valid", packages[0].Name)
require.Equal(t, "2.0.0", packages[0].Version)
require.Equal(t, "valid-pkg", packages[1].Name)
require.Equal(t, "1.0.0", packages[1].Version)
}
18 changes: 18 additions & 0 deletions pkg/analysis/passes/osvscanner/testdata/node/corrupted-pnpm/pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading