Fix Altair GraphQL loading#1202
Merged
Shane32 merged 2 commits intographql-dotnet:masterfrom Oct 25, 2025
Merged
Conversation
Due to recent changes in Altair GraphQL v8.4.0 (updating the angular version and build system which uses native ESM module imports), the current static boilerplate no longer works properly. Updating the script tags as appropriate to conform to the new setup.
1 task
nlampe-bigdutchman
approved these changes
Oct 22, 2025
nlampe-bigdutchman
left a comment
nlampe-bigdutchman
left a comment
There was a problem hiding this comment.
As shown in his code sandbox example (see Comment in altair-graphql/altair#2924 (comment) for details), these changes should solve the issue.
CaiusSacu
reviewed
Oct 24, 2025
CaiusSacu
left a comment
CaiusSacu
left a comment
There was a problem hiding this comment.
looks alright, but shouldn't the runtime script be changed to type module too instead of just plain deleting it?
Shane32
approved these changes
Oct 25, 2025
Contributor
Author
|
@CaiusSacu there is no more runtime.js |
This was referenced Oct 27, 2025
Merged
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1202 +/- ##
===========================================
- Coverage 90.88% 68.26% -22.63%
===========================================
Files 50 123 +73
Lines 2425 4528 +2103
Branches 432 548 +116
===========================================
+ Hits 2204 3091 +887
- Misses 175 1339 +1164
- Partials 46 98 +52 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to recent changes in Altair GraphQL v8.4.0 (updating the angular version and build system which uses native ESM module imports), the current static boilerplate no longer works properly (Sorry about the breaking change!)
Updating the script tags as appropriate to conform to the new setup.
Closes #1201
Given this was a change in a recent version of Altair and the older versions still work with the older template, it might be prudent to use a fixed version of Altair to avoid breaking changes in newer versions breaking GraphQL.Server.Ui.Altair
Here's a codesandbox that uses the updated boilerplate (demo)
FYI jsdelivr allows you to set a major, minor or patch version, so it could be fixed to
cdn.jsdelivr.net/npm/altair-static@8/build/dist/orcdn.jsdelivr.net/npm/altair-static@8.3/build/dist/to still get minor or patch version updates