Skip to content

Ensure all passing user tests are called by their appropriate suite#10259

Open
niloc132 wants to merge 6 commits intogwtproject:mainfrom
niloc132:10258-user-tests-in-suites-test
Open

Ensure all passing user tests are called by their appropriate suite#10259
niloc132 wants to merge 6 commits intogwtproject:mainfrom
niloc132:10258-user-tests-in-suites-test

Conversation

@niloc132
Copy link
Member

Fixes #10258

@niloc132 niloc132 added this to the 2.14 milestone Jan 28, 2026
@niloc132 niloc132 marked this pull request as ready for review February 12, 2026 02:25
@niloc132 niloc132 added the ready This PR has been reviewed by a maintainer and is ready for a CI run. label Feb 12, 2026
@zbynek
Copy link
Collaborator

zbynek commented Feb 18, 2026

Listing all .*Test.java files, comparing with grep result for \w+Test.class in source and eliminating abstract classes + not actual tests gives this:

AbstractSequentialListTest.class - testclass itself not abstract
AtomicReferenceTest.class
BidiFormatterBaseTest.class
EmmaClassLoadingTest.class
HasAlignmentParserTest.class - no GWTTestcase
HorizontalAlignmentConstantParser_Test.class - no GWTTestcase
ImageElementTest.class
LayoutPanelTest.class
NoGenerateJsInteropExportsTest.class (@DoNotRunWith(Platform.Devel))
RPCTypeCheckArraysTest.class - no GWTTestcase
RPCTypeCheckCollectionsTest.class - no GWTTestcase
SafeHtmlBidiFormatterTest.class - no GWTTestcase
SelectionScriptJavaScriptTest.class - no GWTTestcase
StringReaderTest.class
VerticalAlignmentConstantParser_Test.class - no GWTTestcase

PR description specificaly mentions passing tests, I didn't try running any of these. The two test classes with underscore look like old versions of their conventionally named siblings and should be probably deleted.

Copy link
Collaborator

@zbynek zbynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check if some of the classes in my previous comment could/should be enabled too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready This PR has been reviewed by a maintainer and is ready for a CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LocalizableLinkageCreatorTest, others aren't in a suite, is never run

2 participants