-
Notifications
You must be signed in to change notification settings - Fork 1
All features requested in #89 #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Move comments into the main form instead of two pages.
Manually assign judges to teams
Judge team manually by number
Judges manually assigned to a team can now only judge that team
OTP for judges to log in
Judging curves!!
9f049b6 to
9cc7e73
Compare
|
Awesome! I like this PR and I think it looks good. I think the linking of previous feature merges to each feature in the description. I also like the idea of having magic links specifically for judges to make things easier. I think we could probably provide these magic links to every judge to be honest, it may make life a lot easier instead of having some people login and other not. |
|
Awesome! To be clear, judges can ONLY log in through magic link. That is the only way (aside from manual db editing) to assign someone a judge role. They cannot sign in otherwise unless as a participant. They WILL have to provide an email for this (which shouldn't be a problem), but they never have to sign in a different way. If they decide to logout for some reason, in fact, they will need to be reissued a magic link (which is just the invite page again). All participants still have to go through the normal sign in paths, and if we issue them a magic link, they will have a judge account created for them (BAD, DON'T DO THAT). As a side note, checkboxes in the description make "tasks" on GitHub, which I did not know. (and you can drag and drop the checkboxes???) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WTF is that removed stuff
I mean it's fine, its just crazy the amount of comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is smart
YoyoJesus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty solid to me
MR for all requested features in #89
email all teams with their judge score infogive us the ability to assign team numbers to judgesallow us to curve a specific judge's scorepotentially allow judges to manually enter a team numbermove the comment stuff to the bottom of the first formThe other issue is going to be authentication for judges, some will not want to log into the site so we need a solution for that