Skip to content

Conversation

@Monster0506
Copy link
Member

@Monster0506 Monster0506 commented Jan 26, 2026

MR for all requested features in #89

@Monster0506 Monster0506 marked this pull request as draft January 26, 2026 02:23
@Monster0506 Monster0506 mentioned this pull request Jan 26, 2026
@Monster0506 Monster0506 changed the title Send emails to all teams after judging with feedback All features requested in #89 Jan 28, 2026
@Monster0506 Monster0506 requested a review from YoyoJesus January 28, 2026 17:10
@masonbair
Copy link
Contributor

Awesome! I like this PR and I think it looks good. I think the linking of previous feature merges to each feature in the description. I also like the idea of having magic links specifically for judges to make things easier. I think we could probably provide these magic links to every judge to be honest, it may make life a lot easier instead of having some people login and other not.

@Monster0506
Copy link
Member Author

Monster0506 commented Jan 28, 2026

@masonbair

Awesome! To be clear, judges can ONLY log in through magic link. That is the only way (aside from manual db editing) to assign someone a judge role. They cannot sign in otherwise unless as a participant. They WILL have to provide an email for this (which shouldn't be a problem), but they never have to sign in a different way. If they decide to logout for some reason, in fact, they will need to be reissued a magic link (which is just the invite page again).

All participants still have to go through the normal sign in paths, and if we issue them a magic link, they will have a judge account created for them (BAD, DON'T DO THAT).

As a side note, checkboxes in the description make "tasks" on GitHub, which I did not know. (and you can drag and drop the checkboxes???)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WTF is that removed stuff

I mean it's fine, its just crazy the amount of comments

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is smart

Copy link
Member

@YoyoJesus YoyoJesus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty solid to me

@Monster0506 Monster0506 marked this pull request as ready for review January 29, 2026 03:49
@Monster0506 Monster0506 merged commit d903210 into dev Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants