Restore external AnalogRX power function

[pitts-mo]

-Remove conditions for initial setting of AnalogRX power.
-Remove AnalogRX power state change beep.
-Restored AnalogRX power state checking to source selection.

The AnalogRX power state change beep was desirable for testing but seemed to just prompt desire for an optional goggle ready beep feature.

[pitts-mo]

Needs testing on Goggle2.

Boxpro testing?

Should internal analog module power be incorporated into the Auto power function to save power when goggle2/boxpro users switch sources?

[ligenxxxx]

I tested on BoxPro:

• From the source menu, go to analog/an in/hdzero, and the analog module is powered correctly.
• Using the toggle source, the analog module is powered correctly.

[pitts-mo]

If goggle2 is verified I plan to add additional logic for goggle2 internal/external selection.
if analog_module = 1 expansion module is turned ON else (analog_module = 0) expansion module will turn it OFF.

[ligenxxxx]

I noticed that when merging the Google2 code, I introduced some errors in the analog section, causing the external analog module to malfunction.

[pitts-mo]

This PR has been good for me on Goggle v1. If external analog RX power works as expected for v2 it should be good to merge. We can always circle back to add v2 logic enhancement for internal vs external as desired.

[ligenxxxx]

Someone tested this pull request on goggle2, but it didn't work.
I didn't explain myself clearly. When I merged the goggle2 source code into the main branch, I introduced an error during the switch to analog mode, which caused the analog part of goggle2 to malfunction.

[pitts-mo]

Ok, so then goggle v2 merge not only broke the set points but also inverted the logic of the power state?

If so, that was the only difference I saw that I suspected was a hardware change between v1 and v2 external analog power.

[FLORIANSV35]

@ligenxxxx Hi ! I was the one who did the test with the goggles 2.

[pitts-mo]

@FLORIANSV35 you tested this PR prior to commit 0d1478b still did not allow external analog power to function correctly on goggle v2 ? was power state inverted aka external analog on when not using analog?

if so please re-test with commit 0d1478b goggle v2 artifact https://github.com/hd-zero/hdzero-goggle/actions/runs/21749828844/artifacts/5405328691

[FLORIANSV35]

Between internal and external mode there is :

• no change for the source (stuck on internal)
• And no change for power it's stuck on "power on"

Same with 0d1478b

It feel goggle doesn't want to switch to external

[pitts-mo]

@FLORIANSV35 correct. Because I have not yet validated the v2 external analog power state this PR has not yet implemented selection logic for internal vs external.... if internal/module analog is the selected source the external module will always be ON

If you switch to another source while using 0d1478b does the external analog power turn off? when you switch back to internal/module analog does it turn back on?

[pitts-mo]

This may need some back and forth testing since I do not have a Goggle V2 to verify it's external module power switch logic. Additionally, Analog RX Power needs to be set Auto.

[FLORIANSV35]

@pitts-mo Yes when i switch to HDZERO Vrx, external power stop. when i go back to analogue (internal or external) power get back.

With Auto power disable, power stay every time.

@FLORIANSV35 correct. Because I have not yet validated the v2 external analog power state this PR has not yet implemented selection logic for internal vs external.... if internal/module analog is the selected source the external module will always be ON

So it's normal i can't acces to external module video.

[pitts-mo]

Good then then it sounds like the base function of this is now working as expected for goggle v1 and v2.

I like the idea of merging this as-is but I am also interested in creating a separate PR to extend Analog RX Power Auto function into the users internal vs external selection.

[pitts-mo]

I suspect the external analog video not working may be e separate issue... unless we need to force the internal modules power off.

[pitts-mo]

I recall attempting to use the goggle v2 repo as a reference. What is the current functionality of Analog RX Power = Auto when using master builds from the google v2 repo?

[ligenxxxx]

Power is supplied to the analog module only when the user selects the external analog module and accesses it; otherwise, no power is supplied.

[ligenxxxx]

I plan to merge this PR, but there are still issues with goggle2 analog, which are unrelated to this PR.