Conversation
susmita-poddar-hpe
changed the title
hpe3parclient/client.py
Outdated
| return host, hostname | ||
|
|
||
|
|
||
| def queryHostReturnHostname(self, iscsi_iqn=None, wwns=None): |
There was a problem hiding this comment.
Please use iscsi_iqns. because iqn can be one or more
traghavendra
left a comment
traghavendra
left a comment
There was a problem hiding this comment.
Please check comments
hpe3parclient/client.py
Outdated
| return None | ||
|
|
||
|
|
||
| def _get_key_value(self, hpe3par_keys, key, default=None): |
There was a problem hiding this comment.
The variable "hpe3par_keys" is used by cinder. So this function should be part of common.py
hpe3parclient/client.py
Outdated
| rcg_name = vol_details.get('rcopyGroup') | ||
| return rcg_name | ||
|
|
||
| def getStorageSystemIdName(self): |
There was a problem hiding this comment.
The variables 'id' and 'name' are same in all arrays i.e 3par, primera, Alletra 9000 and Alletra MP.
thus, this function can be removed & getStorageSystemInfo() can be used (like in original cinder code).
hpe3parclient/client.py
Outdated
| return info['id'], info['name'] | ||
|
|
||
|
|
||
| def getWsApiVersionBuild(self): |
There was a problem hiding this comment.
same comment as for previous function getStorageSystemIdName().
this function can be removed & getWsApiVersion() can be used (like in original cinder code).
traghavendra
left a comment
traghavendra
left a comment
There was a problem hiding this comment.
Identified few functions that can be kept in cinder code (like original code)
2 participants
Flows - initialize_connection, create_volume, delete_volume, create_snapshot, delete_snapshot, extend_volume (increase size of vol), create_volume_from_snapshot, create_cloned_volume.