Update manual_install_guide_hpe_3par_plg_open_kub#451
Open
ajrich2 wants to merge 1 commit intohpe-storage:masterfrom
Open
Update manual_install_guide_hpe_3par_plg_open_kub#451ajrich2 wants to merge 1 commit intohpe-storage:masterfrom
ajrich2 wants to merge 1 commit intohpe-storage:masterfrom
Conversation
Update manual_install_guide_hpe_3par_plugin_with_openshift_kubernetes.md (Minor changes for 3.0, etcd, and port typo.)
sneharai4
requested changes
Apr 8, 2019
| ```yaml | ||
| sudo docker run -d -v /usr/share/ca-certificates/:/etc/ssl/certs -p 40010:40010 \ | ||
| -p 23800:23800 -p 23790:23790 \ | ||
| sudo docker run -d --restart unless-stopped -v /usr/share/ca-certificates/:/etc/ssl/certs -p 4001:4001 \ |
Collaborator
There was a problem hiding this comment.
Please do not change the ports in the md file as we are using different ports to avoid conflicts with k8s internal etcd.
sneharai4
requested changes
Apr 8, 2019
|
|
||
| devices | ||
| { | ||
| devices{ |
Collaborator
There was a problem hiding this comment.
Please put "device {" also on the same line, the way it is for defaults and devices.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update manual_install_guide_hpe_3par_plugin_with_openshift_kubernetes.md (Minor changes for 3.0, etcd, and port typo.)