1342 enum member called s is not possible#1373
Closed
mihaiboros wants to merge 2 commits intohsutter:mainfrom
Closed
1342 enum member called s is not possible#1373mihaiboros wants to merge 2 commits intohsutter:mainfrom
mihaiboros wants to merge 2 commits intohsutter:mainfrom
Conversation
Owner
|
Thanks for pointing out this problem. In general, this highlights a problem I hadn't noticed before between generated code and user code... the I'll create a commit remove the style rule instead of taking this fix, so I'll close this PR, but thanks for highlighting the problem! |
hsutter
added a commit
that referenced
this pull request
Mar 1, 2025
See #1373 The programmer can always write `this.` to disambiguate. This originally seemed like a useful constraint, but it creates a tension between generated code and user code. For example, see #1373, and the example foo : @enum type = { s; } which before this commit was rejected because the `@enum` type metafunction generates a function with a parameter named `s`. It seems undesirable to force generated code to uglify its names to avoid conflicts. Also, fix `@enum` for cases like this to type-scope-qualify access to the member.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1342
Not a definitive fix, but it will reduce the chance of name clashes and shadowing.