Fix missing explicit for single-argument constructors#1381
Closed
LT2H wants to merge 2 commits intohsutter:mainfrom
Closed
Fix missing explicit for single-argument constructors#1381LT2H wants to merge 2 commits intohsutter:mainfrom
LT2H wants to merge 2 commits intohsutter:mainfrom
Conversation
5e54ba2 to
bd3542c
Compare
Contributor
|
See also 9901b01#r150292780. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should count
out thisas a parameter as well to ensure single-argument constructors are prefixed withexplicit.