Add runtime check for modulo by zero#1405
Conversation
b391976 to
f9442fe
Compare
One of the tests now hits an MSVC error I've seen before, related to using std::source_location via module std import -- it doesn't manifest on any other compiler, or in MSVC using std headers. So the error is spurious, but I'm not able to debug it or find a workaround, and I don't want to record regression test failures just because of that use case where 'module std currently doesn't work.' So this commit also changes all -pure regression tests to use headers, not modules, at least for now until modules work better
|
Thanks! |
|
@hsutter Did you intend to switch from importing std to including std when running the tests? |
That's probably a good idea. @jarzec was maintaining and updating the test runner (thanks again!) -- do those use MSVC modules today which would have required that modules be built somehow (I vaguely recall seeing something like that)? If they do they should probably also switch to use |
EDIT |
|
Regression tests are fixed (among other changes) in #1442 |
Checks for modulo and modulo-assignment by zero at runtime. Based on a suggestion in #1399.
Resolves #1399.