Patch to deal with named_route name collisions...#3
Open
rst wants to merge 1 commit intoianwhite:masterfrom
Open
Patch to deal with named_route name collisions...#3rst wants to merge 1 commit intoianwhite:masterfrom
rst wants to merge 1 commit intoianwhite:masterfrom
Conversation
Resources_controller defined an internal controller method called 'request_path'. If you've got a 'map.resources :requests' in your routes.rb file, that defines a named route called 'request_path'. When these two meet... wackiness ensues! To avoid the wackiness (which manifests as complaints from the code that implements the named route), this patch renames the 'request_path' method, and its companion 'nested_request_path', so that they're no longer at risk of being trampled by eccentric named routes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating my app, I discovered that 'map.resources :requests' breaks recent
versions of resources_controller --- this defines a 'request_path' named route,
which in turn winds up clobbering resources_controller's internal method by
that name.
This is a patch to deal with the issue, by renaming the method to
'path_of_request', which takes it out of the line of fire. Most of it is
updating the specs (which all still pass... at least after a 'mkdir tmp'
so it could create the sqlite3 test db).
FWIW, this is currently lighthouse ticket #9:
http://ianwhite.lighthouseapp.com/projects/10598/tickets/9-request_path-method-gets-clobbered-by-named-routes