Make pconnect cache keys thread-specific#1045
Merged
bimalkjha merged 2 commits intoibmdb:masterfrom Feb 18, 2026
Merged
Conversation
Include thread id in the persistent connection cache key so pconnect entries are isolated per thread. This prevents accidental cross-thread reuse of cached connections. Add regression test for thread safety of persistent connections.
…uction - Ensure PID and thread-id temporary unicode objects are NULL-checked and decref'd after PyUnicode_Concat. - Prevents incremental memory growth in long-running workloads using persistent connections.
bimalkjha
approved these changes
Feb 18, 2026
Contributor
Author
|
Thank you @bimalkjha for reviewing and merging this PR! (And the other one, #1044) Do you know when you can cut a release including these changes? Thanks! |
Member
|
@zenflow We are waiting for few more changes to be merged which are in final stage in our pipeline. We'll have a new release in March. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include thread id in the persistent connection cache key so pconnect entries are isolated per thread.
This prevents accidental cross-thread reuse of cached connections.
Add regression test for thread safety of persistent connections.
This is the PR welcomed by @bimalkjha here: #618 (comment)
Also:
Fix PyUnicode_FromFormat reference leaks in pconnect cache key construction
Ensure PID and thread-id temporary unicode objects are NULL-checked and decref'd after PyUnicode_Concat.
Prevents incremental memory growth in long-running workloads using persistent connections.
The new test passes, but I was unable to run the whole test suite to check for regressions, as I'm not able to create an isolated database instance.
Can someone run the whole test suite and confirm all pass?