feat(textInput): add emoji filtering by default for text inputs#89
Open
diglesias17 wants to merge 5 commits intoindec-it:developfrom
Open
feat(textInput): add emoji filtering by default for text inputs#89diglesias17 wants to merge 5 commits intoindec-it:developfrom
diglesias17 wants to merge 5 commits intoindec-it:developfrom
Conversation
mdumrauf
suggested changes
Feb 28, 2019
Contributor
|
Agregar unit test, de todos los casos |
Contributor
Author
|
mdumrauf
suggested changes
Mar 1, 2019
| }); | ||
|
|
||
| context('with an answer including emojis', () => { | ||
| it('should sanitize it by default', () => { |
| */ | ||
| const handleChangeText = ({name, regex}, value, onChange) => onChange({ | ||
| [name]: !isEmpty(value) ? formatValue(value, regex) : undefined | ||
| const handleChangeText = ({name, regex, allowEmojis = false}, value, onChange) => onChange({ |
Contributor
There was a problem hiding this comment.
Ahora que lo veo mejor, hace lo mismo que el formatValue() 👀.
Se puede simplificar más si concantenás las regex en una sola: https://stackoverflow.com/a/185529. Lo interesante ahora va a ser que el test siga dando verde cuando modifiques la implementación, prescindiendo del sanitize().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.