Skip to content

Add chainable constructor helpers to the AST#32

Draft
jakub-id wants to merge 1 commit intomainfrom
chain-ast
Draft

Add chainable constructor helpers to the AST#32
jakub-id wants to merge 1 commit intomainfrom
chain-ast

Conversation

@jakub-id
Copy link
Contributor

@jakub-id jakub-id commented Feb 3, 2026

This is just an experiment to see how far we can get without the builder.

@jakub-id
Copy link
Contributor Author

jakub-id commented Feb 3, 2026

@adamdickmeiss it's a bit more tricky to use than the builder but much less magic and easier to pass around.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds chainable constructor helpers to the CQL AST package to enable direct construction of query trees without using the builder pattern. It's an experimental approach to simplify query construction.

Changes:

  • Added constructor helper functions (Search, SearchRel, And, Or, Not, Prox, Bool) for building CQL clauses
  • Added chainable With*/Add* methods on all AST types (Query, Clause, SearchClause, BoolClause, Sort, Modifier, Prefix)
  • Added tests demonstrating the new API with complex nested boolean queries

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
cql/chain.go Implements chainable constructor helpers and fluent methods for all AST node types
cql/chain_test.go Tests core functionality with nested AND/OR queries, verifying correct serialization and precedence

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant