Conversation
Contributor
Author
|
@adamdickmeiss it's a bit more tricky to use than the builder but much less magic and easier to pass around. |
There was a problem hiding this comment.
Pull request overview
This PR adds chainable constructor helpers to the CQL AST package to enable direct construction of query trees without using the builder pattern. It's an experimental approach to simplify query construction.
Changes:
- Added constructor helper functions (Search, SearchRel, And, Or, Not, Prox, Bool) for building CQL clauses
- Added chainable With*/Add* methods on all AST types (Query, Clause, SearchClause, BoolClause, Sort, Modifier, Prefix)
- Added tests demonstrating the new API with complex nested boolean queries
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cql/chain.go | Implements chainable constructor helpers and fluent methods for all AST node types |
| cql/chain_test.go | Tests core functionality with nested AND/OR queries, verifying correct serialization and precedence |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just an experiment to see how far we can get without the builder.