Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for testing patron requests with NCIP client integration against the illmock service. The changes enable configuring LMS (Library Management System) settings for test peers, specifically to support NCIP protocol communication.
Changes:
- Extended test helper function to accept custom directory data including LMS configuration
- Updated patron request tests to configure NCIP endpoints for requester and supplier peers
- Added unit test for SetLogFunc in LMS adapter
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| broker/test/apputils/apputils.go | Added customData parameter to CreatePeerWithModeAndVendor function and updated import organization |
| broker/test/patron_request/api/api-handler_test.go | Configured LmsConfig with NCIP addresses for requester and supplier peers in TestCrud and TestActionsToCompleteState |
| broker/test/service/supplierlocator_test.go | Updated function call to match new signature with empty directory.Entry{} |
| broker/lms/lms_adapter_test.go | Added TestSetLogFunc test and updated ncipClientMock to track lastLogFunc |
jakub-id
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patron test uses NCIP client against the illmock