Skip to content

CROSSLINK-209 more testing#393

Merged
adamdickmeiss merged 4 commits intomainfrom
CROSSLINK-209-more-testing
Feb 5, 2026
Merged

CROSSLINK-209 more testing#393
adamdickmeiss merged 4 commits intomainfrom
CROSSLINK-209-more-testing

Conversation

@adamdickmeiss
Copy link
Contributor

Patron test uses NCIP client against the illmock

Copilot AI review requested due to automatic review settings February 5, 2026 18:51
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for testing patron requests with NCIP client integration against the illmock service. The changes enable configuring LMS (Library Management System) settings for test peers, specifically to support NCIP protocol communication.

Changes:

  • Extended test helper function to accept custom directory data including LMS configuration
  • Updated patron request tests to configure NCIP endpoints for requester and supplier peers
  • Added unit test for SetLogFunc in LMS adapter

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
broker/test/apputils/apputils.go Added customData parameter to CreatePeerWithModeAndVendor function and updated import organization
broker/test/patron_request/api/api-handler_test.go Configured LmsConfig with NCIP addresses for requester and supplier peers in TestCrud and TestActionsToCompleteState
broker/test/service/supplierlocator_test.go Updated function call to match new signature with empty directory.Entry{}
broker/lms/lms_adapter_test.go Added TestSetLogFunc test and updated ncipClientMock to track lastLogFunc

@adamdickmeiss adamdickmeiss merged commit 36c61bf into main Feb 5, 2026
3 checks passed
@adamdickmeiss adamdickmeiss deleted the CROSSLINK-209-more-testing branch February 5, 2026 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants