Skip to content

use pymbolic's cached mappers #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matthiasdiener wants to merge 1 commit into
base: main
Choose a base branch
from
Open

use pymbolic's cached mappers #321

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pytato/scalar_expr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,11 @@

from pymbolic.mapper import (WalkMapper as WalkMapperBase, IdentityMapper as
Copy link
Owner

@inducer inducer May 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you characterize the impact of this PR? Any notable compile time improvements? Did anything get worse?

IdentityMapperBase)
from pymbolic.mapper.substitutor import (SubstitutionMapper as
from pymbolic.mapper.substitutor import (CachedSubstitutionMapper as
SubstitutionMapperBase)
from pymbolic.mapper.dependency import (DependencyMapper as
from pymbolic.mapper.dependency import (CachedDependencyMapper as
DependencyMapperBase)
from pymbolic.mapper.evaluator import (EvaluationMapper as
from pymbolic.mapper.evaluator import (CachedEvaluationMapper as
EvaluationMapperBase)
Comment on lines +33 to 38
Copy link
Owner

@inducer inducer May 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change the imported names to include Cached, to avoid misunderstandings?

from pymbolic.mapper.distributor import (DistributeMapper as
DistributeMapperBase)
Expand Down