removes time-editor to use editorv2 by default#3837
Conversation
awildturtok
force-pushed
the
feature/bye-bye-time-editor-v1
branch
from
6613893 to
0071e9f
Compare
experimentally enables SecondaryIds in editorv2
awildturtok
force-pushed
the
feature/bye-bye-time-editor-v1
branch
from
0071e9f to
2f3fe62
Compare
thoniTUB
left a comment
thoniTUB
left a comment
There was a problem hiding this comment.
Hast du auch schon diesen Shortcut Keybind entfernt?
frontend/src/js/model/query.ts
Outdated
| const queryString = JSON.stringify(node.query); | ||
|
|
||
| return TIMEBASED_OPERATOR_TYPES.some((op) => queryString.indexOf(op) !== -1); | ||
| return false; //TODO implement for new time based query ops |
There was a problem hiding this comment.
Ist das jetzt erstmal fertig für diesen PR?
There was a problem hiding this comment.
Ich versuche mal zu schauen wie das vorher umgesetzt war und imitiere es. War glaube nicht so aufwändig.
awildturtok
force-pushed
the
feature/bye-bye-time-editor-v1
branch
from
8af3d4b to
7b354fc
Compare
frontend/src/js/editor-v2/util.ts
Outdated
| } else if (timestamp === "LATEST") { | ||
| return t("editorV2.LATEST"); | ||
| } else { | ||
| } else if (timestamp === "WHILE") { |
There was a problem hiding this comment.
Laut dem TypeGuard kann timestamp gar nicht WHILE sein, und wenn doch, hat das if keinen else case mehr
frontend/src/js/editor-v2/types.ts
Outdated
|
|
||
| export const TIME_TIMESTAMPS: TimeTimestamp[] = [ | ||
| "ALL", | ||
| "ANY", | ||
| "EARLIEST", | ||
| "LATEST", | ||
| ]; | ||
| export const TIME_OPERATORS: TimeOperator[] = ["BEFORE", "AFTER", "WHILE"]; |
There was a problem hiding this comment.
Kann man sich hier die Doppelung sparen? Z.B. so: https://stackoverflow.com/a/59420158
There was a problem hiding this comment.
Das hatte ich kurz ausprobiert, das hat mir dann aber assignments die nicht aus dem array sind erlaubt, was ich merkwürdig fand. vlt aber auch nur intellij bug.
| "@types/redux": "^3.6.0", | ||
| "@typescript-eslint/eslint-plugin": "^6.10.0", | ||
| "@typescript-eslint/parser": "^6.10.0", | ||
| "baseline-browser-mapping": "^2.9.18", |
There was a problem hiding this comment.
das wurde mir von einer der server angekreidet beim starten
awildturtok
force-pushed
the
feature/bye-bye-time-editor-v1
branch
from
82a8992 to
6b8e07c
Compare
2 participants
experimentally enables SecondaryIds in editorv2