Add an ability to use 'isRevealingMask' option#98
Open
IIaJIeHo wants to merge 4 commits intoinsin:masterfrom
Open
Add an ability to use 'isRevealingMask' option#98IIaJIeHo wants to merge 4 commits intoinsin:masterfrom
IIaJIeHo wants to merge 4 commits intoinsin:masterfrom
Conversation
|
+1 I noticed this option today while reading over the inputmask-core docs and would love to have this integrated! Specifically, I think it's annoying when the input is masked with and underscore ("_") or space (" ") and you have to delete back through all that to enter in more text. And when you set the placeholderChar prop to |
|
+1 for this prop. I would also like to see this implemented. |
RajuSuranagi
suggested changes
Feb 22, 2022
| this._updateMaskSelection() | ||
| if (this.mask.input((e.key || e.data))) { | ||
| e.target.value = this.mask.getValue() | ||
| window.mask = this.mask |
There was a problem hiding this comment.
Do we need this change? This is not correct to add a variable directly to window object
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added an ability to use isRevealingMask with this component.
The description for this option is in
https://github.com/insin/inputmask-core#isrevealingmask--boolean