Open
Conversation
- palette switch now possible - open up ways to write structure files - extract MCStructureData for raw file data parsing, i.e. palettes, nbt, blockIndices.. - added file validity checks - split parse into read() (raw file loading) and parse() (data converting) methods to allow lazy loading - Vector3s are BlockPosition instead now TODO remove blockEntity hack
Also ::writePalette() used by fromStructure()
Example:
```php
(new MCStructure(MCStructureData::fromStructure($structure),$structure->getSize(),$structure->getStructureWorldOrigin()))->write("structure".MCStructure::EXTENSION_MCSTRUCTURE);
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently structures can only be read as readonly.
In order to implement rotation in MWE2, write mode is needed.
This PR additionally has:
In hindsight the PR should have been split up into multiple parts, but due to time constraints and code restructuring this was barely possible in a clean way.