Open
Conversation
Contributor
|
Hey! Thanks for the work, I appreciate it! I have a couple of questions about your pull request.
If I check out your fork locally, it won't let me compile the project, because the Paper API requires Java 21, while PlayerStats is built with Java 16. If I change to Java 21, it does compile, but that would mean PlayerStats can't run anymore on servers below Minecraft version 1.20.5, while it currently works on everything above 1.16.5 (that's why I'm building with Java 16 at the moment, so PlayerStats can run on as many different Minecraft versions as possible, without me needing to maintain different projects). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added folia support (tested on 1.21.5) & updated dependencies, removed deprecated api