Adding language on POST payloads containing parameters.#61
Merged
pdowler merged 1 commit intoivoa-std:mainfrom Jun 26, 2025
Merged
Adding language on POST payloads containing parameters.#61pdowler merged 1 commit intoivoa-std:mainfrom
pdowler merged 1 commit intoivoa-std:mainfrom
Conversation
It was not easy picking a place for this. If you add it where we already talk about POST-s, it would appear twice (in sync and async). If you add it where we talk about parameter encoding, it would awkwardly sit next to VOTable content. In the end, I think this location is the least bad one. Content-wise, I considered whether to warn people that in urlencoded parameters they have to replace + with space and in multipart parameters they don't, but I figured that for almost everyone, this is done by some library. And for that reason, I also don't think we should think about it much more -- *unless* this is becoming an issue and http server implementations don't necessarily support urlencoded any more. Do we have indications that that is the case?
mbtaylor
approved these changes
Jun 25, 2025
Member
mbtaylor
left a comment
mbtaylor
left a comment
There was a problem hiding this comment.
Thanks Markus, for me this looks OK. I don't think we need to go into more detail or repeat content from the upstream standards.
Collaborator
|
I agree that this is sufficient. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was not easy picking a place for this. If you add it where we already talk about POST-s, it would appear twice (in sync and async). If you add it where we talk about parameter encoding, it would awkwardly sit next to VOTable content.
In the end, I think this location is the least bad one.
Content-wise, I considered whether to warn people that in urlencoded parameters they have to replace + with space and in multipart parameters they don't, but I figured that for almost everyone, this is done by some library. And for that reason, I also don't think we should think about it much more -- unless this is becoming an issue and http server implementations don't necessarily support urlencoded any more. Do we have indications that that is the case?