Change the 'updated' attribute of the Resource #67
Merged
tomdonaldson merged 1 commit intomasterfrom Jan 31, 2025
Merged
Conversation
msdemlei
approved these changes
Jan 31, 2025
Collaborator
msdemlei
left a comment
There was a problem hiding this comment.
Yes, you're right; the propagation to the harvesting registries should not be triggered by that date (for reasons discussed in sect. 5 of 2014A&C.....7..101D; not sure about the RofR implementation, but if it used the updated attribute, that'd certainly be a problem), but it's still wrong in principle.
Time for amending the submission checklist, I think.
Contributor
|
Confirmed the RofR was not announcing the VOTable resource using a recent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An
updatedattribute of2020-05-11in the RofR is misleading since the resource was just updated for VOTable 1.5 and is likely preventing some downstream propagation of that update.