Allow saving models with feature names that contain spaces and underscores#471
Open
vandenman wants to merge 3 commits intojasp-stats:masterfrom
Open
Allow saving models with feature names that contain spaces and underscores#471vandenman wants to merge 3 commits intojasp-stats:masterfrom
vandenman wants to merge 3 commits intojasp-stats:masterfrom
Conversation
Collaborator
|
Dis you test this with all the regression and classification analyses? I rember it was specific to some analyses. |
Contributor
Author
|
Not all, just boosting and random forest. I'll try out a few more. |
Contributor
Author
|
Just tested it with all regression and classification methods and it worked every time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/jasp-stats/INTERNAL-jasp/issues/2911
To be honest, I couldn't replicate the problem with spaces in the feature names (using https://www.kaggle.com/datasets/yasserh/wine-quality-dataset and the data in jasp-stats/jasp-issues#1686).
@koenderks could you see if you still get the error? Maybe something else got fixed in the meantime so that this no longer happens.