Skip to content

Conversation

@MaxPeal
Copy link

@MaxPeal MaxPeal commented Apr 6, 2022

No description provided.

Signed-off-by: MaxPeal <30347730+MaxPeal@users.noreply.github.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@MaxPeal MaxPeal marked this pull request as ready for review April 6, 2022 21:37
@jauderho
Copy link
Owner

jauderho commented Apr 7, 2022

This PR does not generate the same output as the existing array. Not all upstream repos are built off of a version tag, some are built using HEAD (esp. if the upstream repo is not good about creating regular version tags).

  • ansible has non-standard versioning and requires alternate handling
  • Not all Dockerfiles have ARCHIVE_URL
  • Some Dockerfiles have GIT_URL
  • Not all Dockerfiles are at app/Dockerfile. See nginx-quic directory for example

@MaxPeal
Copy link
Author

MaxPeal commented Apr 7, 2022

Thank you for your feedback,
i can rework the RP to resolve the problems,
if technical are all problems resolve, are will you accept a RP like this or is this not the way / direction do you want do go?

@jauderho
Copy link
Owner

jauderho commented Apr 7, 2022

I'm open to considering this as long as it remains easy to reason about.

It may be easier just to extract the REPO array to a separate file to be updated.

@MaxPeal
Copy link
Author

MaxPeal commented Apr 7, 2022

as of nginx-quic its missing in the ACTION array

"miller" \
"nebula" \
"netmaker" \
"ntfy" \
"octosql" \

do you want that i it exclude in the build of the ACTION array / file?

@jauderho
Copy link
Owner

jauderho commented Apr 7, 2022

as of nginx-quic its missing in the ACTION array

"miller" \
"nebula" \
"netmaker" \
"ntfy" \
"octosql" \

do you want that i it exclude in the build of the ACTION array / file?

This is for a different script rebuildAllGo.sh which is intended only for Go binaries only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants