Reset arg if it was a switch and not an argument#16
Open
sabberworm wants to merge 1 commit intojfd:masterfrom
Open
Reset arg if it was a switch and not an argument#16sabberworm wants to merge 1 commit intojfd:masterfrom
sabberworm wants to merge 1 commit intojfd:masterfrom
Conversation
Contributor
Author
|
I’ve rebased this pull request atop the current master so it should be fine to merge automatically. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following:
passes
"--help"as arg to theexamplehandler even though the--helpswitch will be handled later on. This patch fixes this and passesundefinedto theexamplehandler function.Note: merging this will most likely conflict with pull request #14. Ultimately it should not make much difference whether you put the
arg = undefined;inside or below theifblock.