Skip to content

Fixed unhandled exception when cancel is called on the CancellationToken#6

Open
sam1308 wants to merge 1 commit intojjrdk:masterfrom
sam1308:master
Open

Fixed unhandled exception when cancel is called on the CancellationToken#6
sam1308 wants to merge 1 commit intojjrdk:masterfrom
sam1308:master

Conversation

@sam1308
Copy link

@sam1308 sam1308 commented Mar 8, 2017

Hi, first of all great work!

Code to reproduce:

var cts = new CancellationTokenSource();
var websocket = new WebSocket("ws://1.2.3.4/dummy", cts.Token);

// After any moment in time
cts.Cancel(); // this causes an uncaught TaskCancelledException

Which led me to the async void lambda expression ;)

@Xilconic
Copy link

Xilconic commented Mar 5, 2018

Any update on this pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants