Correct values method comment#356
Open
MarkRS-UK wants to merge 4 commits intojoomla-framework:4.x-devfrom
Open
Correct values method comment#356MarkRS-UK wants to merge 4 commits intojoomla-framework:4.x-devfrom
MarkRS-UK wants to merge 4 commits intojoomla-framework:4.x-devfrom
Conversation
Correct the values method comment to include the case of supplying a DatabaseQuery object as parameter
richard67
previously approved these changes
Feb 18, 2026
Contributor
|
Now after having toggled the base branch forth and back on GitHub, it shows the right changes there and not unrelated ones like it did before. |
richard67
dismissed
their stale review
Hmm, I just see we might need some changes:
- We should use the interface and not the class in the doc block.
- It needs the same doc block change in the QueryInterface.php.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue
Issue discussed today in "Town Square" of Joomla community portal with Richard Fath and Benjamin Trenkle
Summary of Changes
Documentation Changes Required